Re: [PATCH 05/42] mfd: axp20x: use PLATFORM_DEVID_NONE

[Andy Shevchenko]

On Mon, Sep 21, 2020 at 11:52 PM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
>
> Use PLATFORM_DEVID_NONE define instead of "-1" value because:
>  - it brings some meaning,
>  - it might point attention why auto device ID was not used.

Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>

> Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> ---
>  drivers/mfd/axp20x.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
> index aa59496e4376..70aa538a4b64 100644
> --- a/drivers/mfd/axp20x.c
> +++ b/drivers/mfd/axp20x.c
> @@ -967,7 +967,7 @@ int axp20x_device_probe(struct axp20x_dev *axp20x)
>                 return ret;
>         }
>
> -       ret = mfd_add_devices(axp20x->dev, -1, axp20x->cells,
> +       ret = mfd_add_devices(axp20x->dev, PLATFORM_DEVID_NONE, axp20x->cells,
>                               axp20x->nr_cells, NULL, 0, NULL);
>
>         if (ret) {
> --
> 2.17.1
>


-- 
With Best Regards,
Andy Shevchenko