Re: [net-next] net: dsa: felix: convert TAS link speed based on phylink speed

From: Vladimir Oltean
Date: Tue Sep 22 2020 - 07:36:50 EST


Hi Xiaoliang,

On Tue, Sep 22, 2020 at 06:43:02PM +0800, Xiaoliang Yang wrote:
> state->speed holds a value of 10, 100, 1000 or 2500, but
> QSYS_TAG_CONFIG_LINK_SPEED expects a value of 0, 1, 2, 3. So convert the
> speed to a proper value.
>
> Fixes: de143c0e274b ("net: dsa: felix: Configure Time-Aware Scheduler via
> taprio offload")
>
> Signed-off-by: Xiaoliang Yang <xiaoliang.yang_1@xxxxxxx>
> ---

Reviewed-by: Vladimir Oltean <vladimir.oltean@xxxxxxx>

But next time keep in mind the following:

- The Fixes: tag should never wrap on multiple lines, even if it exceeds
80 characters.
- Patches that fix a problem in net-next only should go to David's
net-next tree. Patches that fix a problem on Linus Torvalds' tree
should go to David's "net" tree. This one should go to "net", not to
"net-next".
- All tags (Fixes, Signed-off-by, etc) should be grouped together with
no empty lines between them.

Actually due to the first issue I mentioned, could you please resend
this?

Thanks,
-Vladimir