Re: [PATCH v9 14/18] nitro_enclaves: Add Kconfig for the Nitro Enclaves driver

From: Paraschiv, Andra-Irina
Date: Tue Sep 22 2020 - 10:13:49 EST




On 21/09/2020 15:34, Paraschiv, Andra-Irina wrote:


On 14/09/2020 20:23, Paraschiv, Andra-Irina wrote:


On 14/09/2020 18:59, Greg KH wrote:
On Fri, Sep 11, 2020 at 05:11:37PM +0300, Andra Paraschiv wrote:
Signed-off-by: Andra Paraschiv <andraprs@xxxxxxxxxx>
Reviewed-by: Alexander Graf <graf@xxxxxxxxxx>
I can't take patches without any changelog text at all, sorry.

Same for a few other patches in this series :(


I can move the changelog text before the Sob tag(s) for all the patches. I also can add a summary phrase in the commit message for the commits like this one that have only the commit title and Sob & Rb tags.

Would these updates to the commit messages match the expectations?

Let me know if remaining feedback to discuss and I should include as updates in v10. Otherwise, I can send the new revision with the updated commit messages.

Thanks for review.

Here we go, I published v10, including the updated commit messages and rebased on top of v5.9-rc6.

https://lore.kernel.org/lkml/20200921121732.44291-1-andraprs@xxxxxxxxxx/

Any additional feedback, open to discuss.

If all looks good, we can move forward as we've talked before, to have the patch series on the char-misc branch and target v5.10-rc1.

Thanks for merging the patch series on the char-misc-testing branch and for the review sessions we've had.

Let's see how all goes next; if anything in the meantime to be done (e.g. and not coming via auto-generated mails), just let me know.

Andra



Amazon Development Center (Romania) S.R.L. registered office: 27A Sf. Lazar Street, UBC5, floor 2, Iasi, Iasi County, 700045, Romania. Registered in Romania. Registration number J22/2621/2005.