Re: [PATCH AUTOSEL 5.8 03/20] ASoC: wm8994: Skip setting of the WM8994_MICBIAS register for WM1811

[Sasha Levin]

On Mon, Sep 21, 2020 at 04:07:01PM +0100, Mark Brown wrote:
> On Mon, Sep 21, 2020 at 10:40:10AM -0400, Sasha Levin wrote:
>
> > The WM8994_MICBIAS register is not available in the WM1811 CODEC so skip
> > initialization of that register for that device.
> > This suppresses an error during boot:
> > "wm8994-codec: ASoC: error at snd_soc_component_update_bits on wm8994-codec"
>
> This is pretty much a cosmetic change - previously we were silently not
> reading the register, this just removes the attempt to read it since we
> added an error message in the core.

Right, the only reason I took it is that error message - I find that
bogus error messages have almost the same (bad) impact as real kernel
bugs.

I can drop it if you'd prefer.

--
Thanks,
Sasha