Re: [PATCH 6/6] x86/xen: open code alloc_vm_area in arch_gnttab_valloc

From: Christoph Hellwig
Date: Tue Sep 22 2020 - 10:58:27 EST


On Mon, Sep 21, 2020 at 04:44:10PM -0400, boris.ostrovsky@xxxxxxxxxx wrote:
> This will end up incrementing area->ptes pointer. So perhaps something like
>
>
> pte_t **ptes = area->ptes;
>
> if (apply_to_page_range(&init_mm, (unsigned long)area->area->addr,
>                         PAGE_SIZE * nr_frames, gnttab_apply, &ptes)) {
>
>        ...

Yeah. What do you think of this version? I think it is a little
cleaner and matches what xenbus does. At this point it probably should
be split into a Xen and a alloc_vm_area removal patch, though.

---