Re: [PATCH net-next] net: microchip: Make `lan743x_pm_suspend` function return right value

From: David Miller
Date: Tue Sep 22 2020 - 19:54:32 EST


From: Zheng Yongjun <zhengyongjun3@xxxxxxxxxx>
Date: Mon, 21 Sep 2020 20:08:18 +0800

> @@ -3053,7 +3053,7 @@ static int lan743x_pm_suspend(struct device *dev)
> /* Host sets PME_En, put D3hot */
> ret = pci_prepare_to_sleep(pdev);
>
> - return 0;
> + return ret;
> }

Instead please do:

return pci_preprare_to_sleep(pdev);

And if 'ret' is then completely unused as a result, remove it.