Re: [PATCH 06/10] rpmsg: Turn name service into a stand alone driver
From: kernel test robot
Date: Tue Sep 22 2020 - 21:27:45 EST
Hi Mathieu,
I love your patch! Yet something to improve:
[auto build test ERROR on next-20200921]
[cannot apply to linux/master linus/master rpmsg/for-next v5.9-rc6 v5.9-rc5 v5.9-rc4 v5.9-rc6]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Mathieu-Poirier/rpmsg-Make-RPMSG-name-service-modular/20200922-081745
base: b10b8ad862118bf42c28a98b0f067619aadcfb23
config: arc-allyesconfig (attached as .config)
compiler: arceb-elf-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>
All errors (new ones prefixed by >>):
>> drivers/rpmsg/mtk_rpmsg.c:45:8: error: redefinition of 'struct rpmsg_ns_msg'
45 | struct rpmsg_ns_msg {
| ^~~~~~~~~~~~
In file included from drivers/rpmsg/rpmsg_internal.h:18,
from drivers/rpmsg/mtk_rpmsg.c:14:
include/linux/rpmsg_ns.h:42:8: note: originally defined here
42 | struct rpmsg_ns_msg {
| ^~~~~~~~~~~~
# https://github.com/0day-ci/linux/commit/16d58dca9b736143347676e7d7f0aabbf8e746c0
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Mathieu-Poirier/rpmsg-Make-RPMSG-name-service-modular/20200922-081745
git checkout 16d58dca9b736143347676e7d7f0aabbf8e746c0
vim +45 drivers/rpmsg/mtk_rpmsg.c
7017996951fde84 Pi-Hsun Shih 2019-11-12 34
7017996951fde84 Pi-Hsun Shih 2019-11-12 35 /**
7017996951fde84 Pi-Hsun Shih 2019-11-12 36 * struct rpmsg_ns_msg - dynamic name service announcement message
7017996951fde84 Pi-Hsun Shih 2019-11-12 37 * @name: name of remote service that is published
7017996951fde84 Pi-Hsun Shih 2019-11-12 38 * @addr: address of remote service that is published
7017996951fde84 Pi-Hsun Shih 2019-11-12 39 *
7017996951fde84 Pi-Hsun Shih 2019-11-12 40 * This message is sent across to publish a new service. When we receive these
7017996951fde84 Pi-Hsun Shih 2019-11-12 41 * messages, an appropriate rpmsg channel (i.e device) is created. In turn, the
7017996951fde84 Pi-Hsun Shih 2019-11-12 42 * ->probe() handler of the appropriate rpmsg driver will be invoked
7017996951fde84 Pi-Hsun Shih 2019-11-12 43 * (if/as-soon-as one is registered).
7017996951fde84 Pi-Hsun Shih 2019-11-12 44 */
7017996951fde84 Pi-Hsun Shih 2019-11-12 @45 struct rpmsg_ns_msg {
7017996951fde84 Pi-Hsun Shih 2019-11-12 46 char name[RPMSG_NAME_SIZE];
7017996951fde84 Pi-Hsun Shih 2019-11-12 47 u32 addr;
7017996951fde84 Pi-Hsun Shih 2019-11-12 48 } __packed;
7017996951fde84 Pi-Hsun Shih 2019-11-12 49
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip