Re: [PATCH 10/10] rpmsg: ns: Make Name service module transport agnostic

From: kernel test robot
Date: Tue Sep 22 2020 - 22:40:22 EST

Next message:
Previous message:
In reply to:
Next in thread:
Messages sorted

Hi Mathieu,

I love your patch! Perhaps
[auto build test WARNING [cannot apply to linux/master [If your patch is applied And when submitting patch, # apt-get install sparse
# sparse version: # save the attached make W=1 C=1 CF='-fdiagnostic-prefix
If you fix the issue, Reported-by: kernel test

sparse warnings: (new
drivers/rpmsg/virtio_rpmsg_bus.c:165:43: drivers/rpmsg/virtio_rpmsg_bus.c:165:43: drivers/rpmsg/virtio_rpmsg_bus.c:165:43: drivers/rpmsg/virtio_rpmsg_bus.c:173:31: drivers/rpmsg/virtio_rpmsg_bus.c:173:31: drivers/rpmsg/virtio_rpmsg_bus.c:173:31: drivers/rpmsg/virtio_rpmsg_bus.c:181:43: drivers/rpmsg/virtio_rpmsg_bus.c:181:43: drivers/rpmsg/virtio_rpmsg_bus.c:181:43: drivers/rpmsg/virtio_rpmsg_bus.c:189:31: drivers/rpmsg/virtio_rpmsg_bus.c:189:31: drivers/rpmsg/virtio_rpmsg_bus.c:189:31: >> drivers/rpmsg/virti >> drivers/rpmsg/virti drivers/rpmsg/virtio_rpmsg_bus.c:267:26: >> drivers/rpmsg/virti >> drivers/rpmsg/virti drivers/rpmsg/virtio_rpmsg_bus.c:268:27: drivers/rpmsg/virtio_rpmsg_bus.c:291:26: drivers/rpmsg/virtio_rpmsg_bus.c:291:26: drivers/rpmsg/virtio_rpmsg_bus.c:291:26: drivers/rpmsg/virtio_rpmsg_bus.c:292:27: drivers/rpmsg/virtio_rpmsg_bus.c:292:27: drivers/rpmsg/virtio_rpmsg_bus.c:292:27:
# Description: application/gzip Chunxin Zang: "Re: [External] Re: [PATCH] mm/memcontrol: Add the drop_cache interface for cgroup v2" Guo Ren: "Re: [PATCH] csky: Fix a size determination in gpr_get()" Mathieu Poirier: "[PATCH 10/10] rpmsg: ns: Make Name service module transport agnostic" Mathieu Poirier: "[PATCH 08/10] rpmsg: core: Add RPMSG byte conversion operations" by: [ date ] [ thread ] [ subject ] [ author ] something to improve:
on next-20200921]
linus/master rpmsg/for-next v5.9-rc6 v5.9-rc5 v5.9-rc4 v5.9-rc6]
to the wrong git tree, kindly drop us a note.
we suggest to use '--base' as documented in
//git-scm.com/docs/git-format-patch">https://git-scm.com/docs/git-format-patch]
href="https://github.com/0day-ci/linux/commits/Mathieu-Poirier/rpmsg-Make-RPMSG-name-service-modular/20200922-081745">https://github.com/0day-ci/linux/commits/Mathieu-Poirier/rpmsg-Make-RPMSG-name-service-modular/20200922-081745
8b0f067619aadcfb23
(attached as .config)
9.3.0-15) 9.3.0
v0.6.2-201-g24bdaac6-dirty
.config to linux build tree
-D__CHECK_ENDIAN__' ARCH=i386
kindly add following tag as appropriate
robot <lkp@xxxxxxxxx>
ones prefixed by >>)
sparse: sparse: incorrect type in argument 2 (different base types) @@ expected restricted __virtio16 [usertype] val @@ got unsigned short [usertype] val @@
sparse: expected restricted __virtio16 [usertype] val
sparse: got unsigned short [usertype] val
sparse: sparse: incorrect type in return expression (different base types) @@ expected unsigned short @@ got restricted __virtio16 @@
sparse: expected unsigned short
sparse: got restricted __virtio16
sparse: sparse: incorrect type in argument 2 (different base types) @@ expected restricted __virtio32 [usertype] val @@ got unsigned int [usertype] val @@
sparse: expected restricted __virtio32 [usertype] val
sparse: got unsigned int [usertype] val
sparse: sparse: incorrect type in return expression (different base types) @@ expected unsigned int @@ got restricted __virtio32 @@
sparse: expected unsigned int
sparse: got restricted __virtio32
o_rpmsg_bus.c:267:26: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [addressable] [usertype] addr @@ got restricted __virtio32 @@
o_rpmsg_bus.c:267:26: sparse: expected unsigned int [addressable] [usertype] addr
sparse: got restricted __virtio32
o_rpmsg_bus.c:268:27: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [addressable] [usertype] flags @@ got restricted __virtio32 @@
o_rpmsg_bus.c:268:27: sparse: expected unsigned int [addressable] [usertype] flags
sparse: got restricted __virtio32
sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [addressable] [usertype] addr @@ got restricted __virtio32 @@
sparse: expected unsigned int [addressable] [usertype] addr
sparse: got restricted __virtio32
sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [addressable] [usertype] flags @@ got restricted __virtio32 @@
sparse: expected unsigned int [addressable] [usertype] flags
sparse: got restricted __virtio32
s://github.com/0day-ci/linux/commit/ab159ea48198df2ab06ff9fe97e63cca354bff20">https://github.com/0day-ci/linux/commit/ab159ea48198df2ab06ff9fe97e63cca354bff20
rel="nofollow" href="https://github.com/0day-ci/linux">https://github.com/0day-ci/linux
Mathieu-Poirier/rpmsg-Make-RPMSG-name-service-modular/20200922-081745
6ff9fe97e63cca354bff20
pmsg_bus.c
2020-09-21 167
2020-09-21 168 static u16 virtio_rpmsg_cpu_to_transport16(struct rpmsg_device *rpdev, u16 val)
2020-09-21 169 {
2020-09-21 170 struct virtio_rpmsg_channel *vch = to_virtio_rpmsg_channel(rpdev);
2020-09-21 171 struct virtproc_info *vrp = vch->vrp;
2020-09-21 172
2020-09-21 @173 return cpu_to_virtio16(vrp->vdev, val);
2020-09-21 174 }
2020-09-21 175
2020-09-21 176 static u32 virtio_rpmsg_transport32_to_cpu(struct rpmsg_device *rpdev, u32 val)
2020-09-21 177 {
2020-09-21 178 struct virtio_rpmsg_channel *vch = to_virtio_rpmsg_channel(rpdev);
2020-09-21 179 struct virtproc_info *vrp = vch->vrp;
2020-09-21 180
2020-09-21 @181 return virtio32_to_cpu(vrp->vdev, val);
2020-09-21 182 }
2020-09-21 183
2020-09-21 184 static u32 virtio_rpmsg_cpu_to_transport32(struct rpmsg_device *rpdev, u32 val)
2020-09-21 185 {
2020-09-21 186 struct virtio_rpmsg_channel *vch = to_virtio_rpmsg_channel(rpdev);
2020-09-21 187 struct virtproc_info *vrp = vch->vrp;
2020-09-21 188
2020-09-21 189 return cpu_to_virtio32(vrp->vdev, val);
2020-09-21 190 }
2020-09-21 191
2020-09-21 192 static struct rpmsg_device *
2020-09-21 193 virtio_rpmsg_create_channel(struct rpmsg_device *rpdev,
2020-09-21 194 struct rpmsg_channel_info *chinfo)
2020-09-21 195 {
2020-09-21 196 struct virtio_rpmsg_channel *vch = to_virtio_rpmsg_channel(rpdev);
2020-09-21 197 struct virtproc_info *vrp = vch->vrp;
2020-09-21 198
2020-09-21 199 return __rpmsg_create_channel(vrp, chinfo);
2020-09-21 200 }
2020-09-21 201
2020-09-21 202 static int virtio_rpmsg_release_channel(struct rpmsg_device *rpdev,
2020-09-21 203 struct rpmsg_channel_info *chinfo)
2020-09-21 204 {
2020-09-21 205 struct virtio_rpmsg_channel *vch = to_virtio_rpmsg_channel(rpdev);
2020-09-21 206 struct virtproc_info *vrp = vch->vrp;
2020-09-21 207
2020-09-21 208 return rpmsg_unregister_device(&vrp->vdev->dev, chinfo);
2020-09-21 209 }
2020-09-21 210
2016-09-01 211 static struct rpmsg_endpoint *virtio_rpmsg_create_ept(struct rpmsg_device *rpdev,
2016-09-01 212 rpmsg_rx_cb_t cb,
2016-09-01 213 void *priv,
2016-09-01 214 struct rpmsg_channel_info chinfo)
2016-09-01 215 {
2016-09-01 216 struct virtio_rpmsg_channel *vch = to_virtio_rpmsg_channel(rpdev);
2016-09-01 217
2016-09-01 218 return __rpmsg_create_ept(vch->vrp, rpdev, cb, priv, chinfo.src);
2016-09-01 219 }
2016-09-01 220
2011-10-20 221 /**
2012-02-09 222 * __rpmsg_destroy_ept() - destroy an existing rpmsg endpoint
2012-02-09 223 * @vrp: virtproc which owns this ept
2011-10-20 224 * @ept: endpoing to destroy
2011-10-20 225 *
2012-02-09 226 * An internal function which destroy an ept without assuming it is
2012-02-09 227 * bound to an rpmsg channel. This is needed for handling the internal
2012-02-09 228 * name service endpoint, which isn't bound to an rpmsg channel.
2012-02-09 229 * See also __rpmsg_create_ept().
2011-10-20 230 */
2012-02-09 231 static void
2012-02-09 232 __rpmsg_destroy_ept(struct virtproc_info *vrp, struct rpmsg_endpoint *ept)
2011-10-20 233 {
2012-06-07 234 /* make sure new inbound messages can't find this ept anymore */
2011-10-20 235 mutex_lock(&vrp->endpoints_lock);
2011-10-20 236 idr_remove(&vrp->endpoints, ept->addr);
2011-10-20 237 mutex_unlock(&vrp->endpoints_lock);
2011-10-20 238
2012-06-07 239 /* make sure in-flight inbound messages won't invoke cb anymore */
2012-06-07 240 mutex_lock(&ept->cb_lock);
2012-06-07 241 ept->cb = NULL;
2012-06-07 242 mutex_unlock(&ept->cb_lock);
2012-06-07 243
2012-06-06 244 kref_put(&ept->refcount, __ept_release);
2011-10-20 245 }
2012-02-09 246
2016-09-01 247 static void virtio_rpmsg_destroy_ept(struct rpmsg_endpoint *ept)
2016-09-01 248 {
2016-09-01 249 struct virtio_rpmsg_channel *vch = to_virtio_rpmsg_channel(ept->rpdev);
2016-09-01 250
2016-09-01 251 __rpmsg_destroy_ept(vch->vrp, ept);
2016-09-01 252 }
2016-09-01 253
2016-09-01 254 static int virtio_rpmsg_announce_create(struct rpmsg_device *rpdev)
2016-09-01 255 {
2016-09-01 256 struct virtio_rpmsg_channel *vch = to_virtio_rpmsg_channel(rpdev);
2016-09-01 257 struct virtproc_info *vrp = vch->vrp;
2016-09-01 258 struct device *dev = &rpdev->dev;
2016-09-01 259 int err = 0;
2016-09-01 260
2011-10-20 261 /* need to tell remote processor's name service about this channel ? */
2017-06-02 262 if (rpdev->announce && rpdev->ept &&
2011-10-20 263 virtio_has_feature(vrp->vdev, VIRTIO_RPMSG_F_NS)) {
2011-10-20 264 struct rpmsg_ns_msg nsm;
2011-10-20 265
2011-10-20 266 strncpy(nsm.name, rpdev->id.name, RPMSG_NAME_SIZE);
Liakhovetski 2020-07-21 @267 nsm.addr = cpu_to_virtio32(vrp->vdev, rpdev->ept->addr);
Liakhovetski 2020-07-21 @268 nsm.flags = cpu_to_virtio32(vrp->vdev, RPMSG_NS_CREATE);
2011-10-20 269
2016-09-01 270 err = rpmsg_sendto(rpdev->ept, &nsm, sizeof(nsm), RPMSG_NS_ADDR);
2011-10-20 271 if (err)
2011-10-20 272 dev_err(dev, "failed to announce service %d\n", err);
2011-10-20 273 }
2011-10-20 274
2011-10-20 275 return err;
2011-10-20 276 }
2011-10-20 277
Intel Corporation
//lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx">https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
>.config.gz

Next message: Chunxin Zang: "Re: [External] Re: [PATCH] mm/memcontrol: Add the drop_cache interface for cgroup v2"
Previous message: Guo Ren: "Re: [PATCH] csky: Fix a size determination in gpr_get()"
In reply to: Mathieu Poirier: "[PATCH 10/10] rpmsg: ns: Make Name service module transport agnostic"
Next in thread: Mathieu Poirier: "[PATCH 08/10] rpmsg: core: Add RPMSG byte conversion operations"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]