Re: [PATCH v2 0/4] i2c-hid: Save power by reducing i2c xfers with block reads

From: Sultan Alsawaf
Date: Wed Sep 23 2020 - 02:02:36 EST


On Tue, Sep 22, 2020 at 09:59:44PM +0200, Jiri Kosina wrote:
> On Tue, 22 Sep 2020, Wolfram Sang wrote:
>
> > > Hans, Benjamin, could you please give this patchset some smoke-testing? It
> > > looks good to me, but I'd like it to get some testing from your testing
> > > machinery before merging.
> >
> > Please give me some more days. I am not fully convinced yet that this
> > use of I2C_M_RECV_LEN is not broken on some controllers.
> >
> > Plus, I'd favor if this could go via I2C tree. It is within I2C where
> > the non-trivial changes are. The HID part is just the final bit. Can we
> > agree on that?
>
> Absolutely no problem with that. But I'd like to have this ran through
> Benjamin/Hans first too.
>
> Thanks,
>
> --
> Jiri Kosina
> SUSE Labs
>

I suppose the HID part does need to be held off until all the adapters are
updated with functional I2C_M_RECV_LEN bits.

I just got a Ryzen laptop which panics when using I2C_M_RECV_LEN.

So it looks like only the designware changes can be considered for merging now.

Sultan