Re: [PATCH 4/5] fscrypt: Have filesystems handle their d_ops

From: Eric Biggers
Date: Wed Sep 23 2020 - 02:09:37 EST

On Wed, Sep 23, 2020 at 01:01:50AM +0000, Daniel Rosenberg wrote:
> This shifts the responsibility of setting up dentry operations from
> fscrypt to the individual filesystems, allowing them to have their own
> operations while still setting fscrypt's d_revalidate as appropriate.
> Most filesystems can just use generic_set_encrypted_ci_d_ops, unless
> they have their own specific dentry operations as well. That operation
> will set the minimal d_ops required under the circumstances.
> Since the fscrypt d_ops are set later on, we must set all d_ops there,
> since we cannot adjust those later on. This should not result in any
> change in behavior.
> Signed-off-by: Daniel Rosenberg <drosen@xxxxxxxxxx>

Looks good,

Reviewed-by: Eric Biggers <ebiggers@xxxxxxxxxx>