Re: [PATCH 4.19] dmaengine: at_hdmac: Fix memory leak

[Ludovic Desroches]

On Sun, Sep 20, 2020 at 10:28:38AM +0200, Pavel Machek wrote:
> Date: Sun, 20 Sep 2020 10:28:38 +0200
> From: Pavel Machek <pavel@xxxxxx>
> To: linux-kernel@xxxxxxxxxxxxxxx, dmaengine@xxxxxxxxxxxxxxx,
>  linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, dan.j.williams@xxxxxxxxx,
>  vkoul@xxxxxxxxxx, ludovic.desroches@xxxxxxxxxxxxx, stable@xxxxxxxxxxxxxxx,
>  Greg KH <greg@xxxxxxxxx>
> Subject: [PATCH 4.19] dmaengine: at_hdmac: Fix memory leak
> 
> 
> This fixes memory leak in at_hdmac. Mainline does not have the same
> problem.
> 
> Signed-off-by: Pavel Machek (CIP) <pavel@xxxxxxx>
Acked-by: Ludovic Desroches <ludovic.desroches@xxxxxxxxxxxxx>

Thanks.

> 
> diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c
> index 86427f6ba78c..0847b2055857 100644
> --- a/drivers/dma/at_hdmac.c
> +++ b/drivers/dma/at_hdmac.c
> @@ -1714,8 +1714,10 @@ static struct dma_chan *at_dma_xlate(struct of_phandle_args *dma_spec,
>  	atslave->dma_dev = &dmac_pdev->dev;
>  
>  	chan = dma_request_channel(mask, at_dma_filter, atslave);
> -	if (!chan)
> +	if (!chan) {
> +		kfree(atslave);
>  		return NULL;
> +	}
>  
>  	atchan = to_at_dma_chan(chan);
>  	atchan->per_if = dma_spec->args[0] & 0xff;
> 
> -- 
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html