Re: [PATCH -next] sched: Remove unused inline function uclamp_bucket_base_value()

From: Dietmar Eggemann
Date: Wed Sep 23 2020 - 06:22:07 EST


On 22/09/2020 15:24, YueHaibing wrote:
> There is no caller in tree, so can remove it.
>
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
> ---
> kernel/sched/core.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index 2d95dc3f4644..1b06b952dbbe 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -940,11 +940,6 @@ static inline unsigned int uclamp_bucket_id(unsigned int clamp_value)
> return clamp_value / UCLAMP_BUCKET_DELTA;
> }
>
> -static inline unsigned int uclamp_bucket_base_value(unsigned int clamp_value)
> -{
> - return UCLAMP_BUCKET_DELTA * uclamp_bucket_id(clamp_value);
> -}
> -
> static inline unsigned int uclamp_none(enum uclamp_id clamp_id)
> {
> if (clamp_id == UCLAMP_MIN)
>

LGTM.

It got introduced in commit 60daf9c194106 ("sched/uclamp: Add bucket
local max tracking") but was never used.

Reviewed-by: Dietmar Eggemann <dietmar.eggemann@xxxxxxx>