Re: [PATCH 2/2] arm64: dts: rockchip: rk3399-khadas-edge add missed ir-receiver and ir_rx pinctl nodes

[Heiko Stübner]

Hi Artem,

Am Mittwoch, 23. September 2020, 12:12:25 CEST schrieb Artem Lapkin:
> From: Artem Lapkin <art@xxxxxxxxxx>
> 
> add missed ir receivier to Khadas Edge board
> Khadas Edge uses gpio-ir-receiver on RK_PB6 gpio

Missing Signed-off-by

> ---
>  .../boot/dts/rockchip/rk3399-khadas-edge.dtsi    | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi
> index 42ebbd6fa46..389ae43d869 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi
> @@ -109,6 +109,14 @@ vsys_5v0: vsys-5v0 {
>  		vin-supply = <&vsys>;
>  	};
>  
> +	ir-receiver {

please sort alphabetically.

Also more importantly, is this really part of all Khadas Edge board variants?
[just making sure ;-) ]

> +		compatible = "gpio-ir-receiver";
> +		gpios = <&gpio1 RK_PB6 GPIO_ACTIVE_LOW>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&ir_rx>;
> +		linux,rc-map-name = "rc-khadas";
> +	};
> +
>  	adc-keys {
>  		compatible = "adc-keys";
>  		io-channels = <&saradc 1>;
> @@ -682,6 +690,14 @@ &sdmmc {
>  	status = "okay";
>  };
>  
> +&pinctrl {

there is already a "&pinctrl" node in the "rk3399-khadas-edge.dtsi"
please don't add another one, and make sure things are somewhat
sorted alphabetically ;-) .

Thanks
Heiko

> +    ir {
> +	ir_rx: ir-rx {
> +	    rockchip,pins = <1 RK_PB6 RK_FUNC_GPIO &pcfg_pull_none>;
> +	};
> +    };
> +};
> +
>  &sdhci {
>  	bus-width = <8>;
>  	mmc-hs400-1_8v;
>