Re: [RFC PATCH 07/12] rcu: Shutdown nocb timer on de-offloading

From: Paul E. McKenney
Date: Wed Sep 23 2020 - 11:47:43 EST


On Wed, Sep 23, 2020 at 05:29:52PM +0200, Frederic Weisbecker wrote:
> On Mon, Sep 21, 2020 at 05:17:56PM -0700, Paul E. McKenney wrote:
> > On Mon, Sep 21, 2020 at 02:43:46PM +0200, Frederic Weisbecker wrote:
> > > Make sure the nocb timer can't fire anymore before we reach the final
> > > de-offload state. Spuriously waking up the GP kthread is no big deal but
> > > we must prevent from executing the timer callback without nocb locking.
> >
> > If we had just the previous patch and not this patch, would things break?
> > Or are you relying on the fact that there is not yet a connection to
> > userspace controls for this functionality?
>
> Exactly it shouldn't break because only the last patch makes the code
> eventually used.

That works, thank you!

Thanx, Paul