Re: [RFC PATCH 05/12] rcu: De-offloading GP kthread

From: Paul E. McKenney
Date: Wed Sep 23 2020 - 11:48:24 EST


On Wed, Sep 23, 2020 at 05:31:32PM +0200, Frederic Weisbecker wrote:
> On Mon, Sep 21, 2020 at 05:10:15PM -0700, Paul E. McKenney wrote:
> > On Mon, Sep 21, 2020 at 02:43:44PM +0200, Frederic Weisbecker wrote:
> > > @@ -2292,6 +2340,7 @@ void __init rcu_init_nohz(void)
> > > rcu_segcblist_init(&rdp->cblist);
> > > rcu_segcblist_offload(&rdp->cblist, true);
> > > rcu_segcblist_set_flags(&rdp->cblist, SEGCBLIST_KTHREAD_CB);
> > > + rcu_segcblist_set_flags(&rdp->cblist, SEGCBLIST_KTHREAD_GP);
> >
> > OK, I will bite at this nit...
> >
> > Why not "SEGCBLIST_KTHREAD_CB | SEGCBLIST_KTHREAD_GP"?
>
> That spared a broken line :o)
>
> But you're right, I'll do that.

Either way is fine, just curious. Your choice!

Thanx, Paul