Re: [PATCH v4] Introduce support for Systems Management Driver over WMI for Dell Systems

From: Randy Dunlap
Date: Wed Sep 23 2020 - 13:11:50 EST


Hi,

On 9/23/20 4:30 AM, Divya Bharathi wrote:
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 40219bba6801..4fd7a3f0a904 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -430,6 +430,18 @@ config DELL_WMI
> To compile this driver as a module, choose M here: the module will
> be called dell-wmi.
>
> +config DELL_WMI_SYSMAN
> + tristate "Dell WMI Systems management WMI driver"

Could you drop one of those "WMI" strings or are both of them needed?

> + depends on ACPI_WMI
> + depends on DMI
> + select NLS
> + help
> + This driver allows changing BIOS settings on many Dell machines from
> + 2018 and newer without the use of any additional software.
> +
> + To compile this driver as a module, choose M here: the module will
> + be called dell-wmi-sysman.

thanks.
--
~Randy