Re: [PATCH v4] Introduce support for Systems Management Driver over WMI for Dell Systems

From: Randy Dunlap
Date: Wed Sep 23 2020 - 14:41:49 EST


On 9/23/20 11:39 AM, Limonciello, Mario wrote:
>> -----Original Message-----
>> From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
>> Sent: Wednesday, September 23, 2020 12:12
>> To: Divya Bharathi; dvhart@xxxxxxxxxxxxx
>> Cc: LKML; platform-driver-x86@xxxxxxxxxxxxxxx; Bharathi, Divya; Hans de Goede;
>> Andy Shevchenko; mark gross; Limonciello, Mario; Ksr, Prasanth
>> Subject: Re: [PATCH v4] Introduce support for Systems Management Driver over
>> WMI for Dell Systems
>>
>>
>> [EXTERNAL EMAIL]
>>
>> Hi,
>>
>> On 9/23/20 4:30 AM, Divya Bharathi wrote:
>>> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
>>> index 40219bba6801..4fd7a3f0a904 100644
>>> --- a/drivers/platform/x86/Kconfig
>>> +++ b/drivers/platform/x86/Kconfig
>>> @@ -430,6 +430,18 @@ config DELL_WMI
>>> To compile this driver as a module, choose M here: the module will
>>> be called dell-wmi.
>>>
>>> +config DELL_WMI_SYSMAN
>>> + tristate "Dell WMI Systems management WMI driver"
>>
>> Could you drop one of those "WMI" strings or are both of them needed?
>>
>
> Thanks, that's a good suggestion. How about instead:
>
> "Dell WMI based Systems management driver"

WMI-based

OK. Thanks.

--
~Randy