Re: [PATCH 1/7] efi: pstore: disentangle from deprecated efivars module

[Ard Biesheuvel]

On Wed, 23 Sep 2020 at 20:41, Kees Cook <keescook@xxxxxxxxxxxx> wrote:
>
> On Wed, Sep 23, 2020 at 06:13:58PM +0200, Ard Biesheuvel wrote:
> > The EFI pstore implementation relies on the 'efivars' abstraction,
> > which encapsulates the EFI variable store in a way that can be
> > overridden by other backing stores, like the Google SMI one.
> >
> > On top of that, the EFI pstore implementation also relies on the
> > efivars.ko module, which is a separate layer built on top of the
> > 'efivars' abstraction that exposes the [deprecated] sysfs entries
> > for each variable that exists in the backing store.
> >
> > Since the efivars.ko module is deprecated, and all users appear to
> > have moved to the efivarfs file system instead, let's prepare for
> > its removal, by removing EFI pstore's dependency on it.
> >
> > Signed-off-by: Ard Biesheuvel <ardb@xxxxxxxxxx>
>
> With this and the other pstore patch, do the pstore self-tests still
> pass on an EFI system?
>
> If so, please consider both:
>
> Acked-by: Kees Cook <keescook@xxxxxxxxxxxx>
>

Selftests? Excellent! Are they documented too?