RE: [PATCH v2 2/2] dt: bindings: ath10k: Document qcom,ath10k-pre-calibration-data-mtd

From: ansuelsmth
Date: Wed Sep 23 2020 - 17:04:27 EST




> -----Original Message-----
> From: Rob Herring <robh@xxxxxxxxxx>
> Sent: Wednesday, September 23, 2020 10:58 PM
> To: Ansuel Smith <ansuelsmth@xxxxxxxxx>
> Cc: Kalle Valo <kvalo@xxxxxxxxxxxxxx>; David S. Miller
> <davem@xxxxxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; linux-
> wireless@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> ath10k@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH v2 2/2] dt: bindings: ath10k: Document qcom,ath10k-
> pre-calibration-data-mtd
>
> On Fri, Sep 18, 2020 at 08:11:03PM +0200, Ansuel Smith wrote:
> > Document use of qcom,ath10k-pre-calibration-data-mtd bindings used to
> > define from where the driver will load the pre-cal data in the defined
> > mtd partition.
> >
> > Signed-off-by: Ansuel Smith <ansuelsmth@xxxxxxxxx>
> > ---
> > .../devicetree/bindings/net/wireless/qcom,ath10k.txt | 12 +++++++++---
> > 1 file changed, 9 insertions(+), 3 deletions(-)
> >
> > diff --git
> a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
> b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
> > index b61c2d5a0..568364243 100644
> > --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
> > +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
> > @@ -15,9 +15,9 @@ and also uses most of the properties defined in this
> doc (except
> > "qcom,ath10k-calibration-data"). It uses "qcom,ath10k-pre-calibration-
> data"
> > to carry pre calibration data.
> >
> > -In general, entry "qcom,ath10k-pre-calibration-data" and
> > -"qcom,ath10k-calibration-data" conflict with each other and only one
> > -can be provided per device.
> > +In general, entry "qcom,ath10k-pre-calibration-data",
> > +"qcom,ath10k-calibration-data-mtd" and "qcom,ath10k-calibration-
> data" conflict with
> > +each other and only one can be provided per device.
> >
> > SNOC based devices (i.e. wcn3990) uses compatible string
> "qcom,wcn3990-wifi".
> >
> > @@ -63,6 +63,12 @@ Optional properties:
> > hw versions.
> > - qcom,ath10k-pre-calibration-data : pre calibration data as an array,
> > the length can vary between hw
versions.
> > +- qcom,ath10k-pre-calibration-data-mtd :
>
> mtd is a Linuxism.
>
> > + Usage: optional
> > + Value type: <phandle offset size>
> > + Definition: pre calibration data read from mtd partition. Take 3
> value, the
> > + mtd to read data from, the offset in the mtd partition
and
> the
>
> The phandle is the mtd or partition?
>
> Maybe you should be using nvmem binding here.
>

The phandle is to the mtd.
You are right about nvmem... Problem is that nvmem for mtd is still not
supported. I already sent a patch to fix this in the mtd mailing list but
I'm waiting for review...
If that will be accepted, I can convert this patch to use nvmem api.

> > + size of data to read.
> > - <supply-name>-supply: handle to the regulator device tree node
> > optional "supply-name" are "vdd-0.8-cx-mx",
> > "vdd-1.8-xo", "vdd-1.3-rfa", "vdd-3.3-ch0",
> > --
> > 2.27.0
> >