Re: [PATCH v4 0/6] Perf tool: Support TSC for Arm64
From: Leo Yan
Date: Wed Sep 23 2020 - 19:48:43 EST
Hi Arnaldo,
On Wed, Sep 23, 2020 at 12:55:57PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Wed, Sep 23, 2020 at 12:27:53PM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Tue, Sep 22, 2020 at 01:49:06PM -0300, Arnaldo Carvalho de Melo escreveu:
> > > Em Tue, Sep 22, 2020 at 08:07:32PM +0800, Leo Yan escreveu:
> > > > Hi Arnaldo,
> > > >
> > > > On Mon, Sep 14, 2020 at 07:53:05PM +0800, Leo Yan wrote:
> > > > > This patch set is to refactor TSC implementation and move TSC code from
> > > > > x86 folder to util/tsc.c, this allows all archs to reuse the code. And
> > > > > alse move the TSC testing from x86 folder to tests so can work as a
> > > > > common testing.
> > > > >
> > > > > So far, for x86 it needs to support cap_user_time_zero and for Arm64
> > > > > it needs to support cap_user_time_short. For architecture specific
> > > > > code, every arch only needs to implement its own rdtsc() to read out
> > > > > timer's counter.
> > > > >
> > > > > This patch set has been rebased on the perf/core branch with latest
> > > > > commit b1f815c479c1 ("perf vendor events power9: Add hv_24x7 core level
> > > > > metric events") and tested on Arm64 DB410c.
> > > >
> > > > Could you pick up this patch set? Thanks!
> > >
> > > Yeah, I picked it up now, its a pity nobody provided Acks :-\
> > >
> > > Or have a missed them somehow?
> >
> > Also:
>
> So, this is the first:
>
> commit 0ab58c405dd7c143a1482cb9414eb0eb9b31d42a (HEAD)
> Author: Leo Yan <leo.yan@xxxxxxxxxx>
> Date: Mon Sep 14 19:53:10 2020 +0800
>
> perf tests tsc: Make tsc testing as a common testing
>
> I'll remove it and the ones after that, so the main feature is kept.
>
> I'll retest, and then push to perf/core you can then continue from
> there.
Will monitor perf/core branch and after you push onto it, I will fix
the issue ASAP. Sorry for inconvenience.
Thanks,
Leo