Re: [PATCH net] Revert "ravb: Fixed to be able to unload modules"
From: David Miller
Date: Wed Sep 23 2020 - 20:40:08 EST
From: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
Date: Tue, 22 Sep 2020 09:29:31 +0200
> This reverts commit 1838d6c62f57836639bd3d83e7855e0ee4f6defc.
> This commit moved the ravb_mdio_init() call (and thus the
> of_mdiobus_register() call) from the ravb_probe() to the ravb_open()
> call. This causes a regression during system resume (s2idle/s2ram), as
> new PHY devices cannot be bound while suspended.
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx
I noticed this too late, but please don't CC: stable on networking
patches. We have our own workflow as per the netdev FAQ.
I've applied this but the inability to remove a module is an
extremely serious bug and should be fixed properly.