Re: [PATCH v2] ide/macide: Convert Mac IDE driver to platform driver

[Michael Schmitz]

Hi Finn,

On 24/09/20 1:07 PM, Finn Thain wrote:
> Looking further at the drivers using ide_host_register(), I see that
> falconide.c is missing a set_drvdata() call, while tx4939ide.c calls
> set_drvdata() after ide_host_register(). The latter example is not a bug.
>
> The pattern I used, that is, calling set_drvdata() after ide_host_add(),
> is actually more popular among IDE drivers than the pattern you suggested,
> that is, set_drvdata() followed by ide_host_register(). Either way, I
> don't see any bugs besides the one in falconide.c.
>
> Regarding falconide.c, my inclination is to send a fix following the more
> common pattern (among IDE drivers), as below. I guess that may prompt the
> subsystem maintainers to make known their views on the style question.

Please do - that is clearly a bug. I must admit I never tried to boot my 
Falcon off a SCSI partition to test falconide module unload.

Cheers,

    Michael


> diff --git a/drivers/ide/falconide.c b/drivers/ide/falconide.c
> index dbeb2605e5f6e..607c44bc50f1b 100644
> --- a/drivers/ide/falconide.c
> +++ b/drivers/ide/falconide.c
> @@ -166,6 +166,7 @@ static int __init falconide_init(struct platform_device *pdev)
>   	if (rc)
>   		goto err_free;
>   
> +	platform_set_drvdata(pdev, host);
>   	return 0;
>   err_free:
>   	ide_host_free(host);
> @@ -176,7 +177,7 @@ static int __init falconide_init(struct platform_device *pdev)
>   
>   static int falconide_remove(struct platform_device *pdev)
>   {
> -	struct ide_host *host = dev_get_drvdata(&pdev->dev);
> +	struct ide_host *host = platform_get_drvdata(pdev);
>   
>   	ide_host_remove(host);
>