Re: [PATCH 4.19 43/49] Input: trackpoint - add new trackpoint variant IDs

From: Vincent Huang
Date: Wed Sep 23 2020 - 22:16:53 EST

On 9/24/20 4:42 AM, Dmitry Torokhov wrote:
CAUTION: Email originated externally, do not click links or open attachments unless you recognize the sender and know the content is safe.

On Tue, Sep 22, 2020 at 10:24:03PM +0200, Pavel Machek wrote:
On Tue 2020-09-22 18:16:42, Greg Kroah-Hartman wrote:
On Tue, Sep 22, 2020 at 05:39:57PM +0200, Pavel Machek wrote:

From: Vincent Huang <vincent.huang@xxxxxxxxxxxxxxxx>

commit 6c77545af100a72bf5e28142b510ba042a17648d upstream.

Add trackpoint variant IDs to allow supported control on Synaptics
This just adds unused definitions. I don't think it is needed in
It add support for a new device.
No, it does not. Maybe in mainline there's followup patch that adds
such support, but that's not in 4.19.
es, indeed, there is a chunk missing, so this patch is incomplete. It
will not cause any issues if applied, so I'll leave it to Greg to decide
what to do with this.

Vincent, there needs to be a change in trackpoint_start_protocol() to
mark these new IDs as valid. Was it s3ent in a separate patch and I
missed it?

Hi Dmitry:

You are right, I think the code is missing in start_protocol(), I'll send one patch to complete it.