Re: [PATCH v2] omap3: enable off mode automatically

[Tony Lindgren]

* Andreas Kemnade <andreas@xxxxxxxxxxxx> [200924 07:00]:
> On Fri, 11 Sep 2020 18:12:09 +0200
> Andreas Kemnade <andreas@xxxxxxxxxxxx> wrote:
> 
> > Enabling off mode was only reachable deeply hidden
> > in the debugfs. As powersaving is an important feature,
> > move the option out of its shady place.
> > The debugfs file can still be used to override the default.
> > 
> > Use the presence of a device compatible to ti,twl4030-idle or
> > ti,twl4030-idle-osc-off as an indicator that the board is wired correctly
> > for off mode.
> > 
> > Signed-off-by: Andreas Kemnade <andreas@xxxxxxxxxxxx>
> > ---
> > An earlier version of this patch was here:
> > https://patchwork.kernel.org/patch/10794121/
> > 
> > A config option was used instead of the suggested devicetree check.
> > 
> > Changes in v2:
> > - fix compile without CONFIG_ARCH_OMAP3
> >   The variable enable_off_mode is now always a real one and not
> >   a preprocessor constant to avoid trouble with unusual configurations.
> > 
> Anything I still missed here? 

No the missing part is just me picking up the remaining patches
for v5.10 that I'll hopefully manage to do today :)

Regards,

Tony