Re: [PATCH v3 2/3] dt-bindings: usb: cdns,usb3: Add cdns,phyrst-a-enable property

[Roger Quadros]

Hi Sergei,

On 15/09/2020 19:15, Sergei Shtylyov wrote:
> Hello!
>
> On 9/15/20 2:45 PM, Roger Quadros wrote:
>
> > Controller version 0x0002450D has USB2 PHY RX sensitivity issues
> > that needs to be worked around by enabling phyrst-a-enable bit
> > in PHYRST_CFG register.
> >
> > There is no way to know controller version before device controller
> > is started and the workaround needs to be applied for both host and
> > device modes, so we add this DT property.
> >
> > Signed-off-by: Roger Quadros <rogerq@xxxxxx>
> > Acked-by: Rob Herring <robh@xxxxxxxxxx>
> > ---
> >   Documentation/devicetree/bindings/usb/cdns,usb3.yaml | 4 ++++
> >   1 file changed, 4 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/cdns,usb3.yaml b/Documentation/devicetree/bindings/usb/cdns,usb3.yaml
> > index 9b14c8443d39..ac20b98e9910 100644
> > --- a/Documentation/devicetree/bindings/usb/cdns,usb3.yaml
> > +++ b/Documentation/devicetree/bindings/usb/cdns,usb3.yaml
> > @@ -61,6 +61,10 @@ properties:
> >         buffers expressed in KB
> >       $ref: /schemas/types.yaml#/definitions/uint32
> >   
> > +  cdns,phyrst-a-enable:
> > +    description: Enable resetting of PHY if Rx fail is detected
>
>     Failure?

Actually the IP manual says "Reset PHY if Rx fail is detected".

So let's leave it like that.
> [...]
>
> MBR, Sergei

cheers,
-roger
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki