Re: [PATCH v2 1/5] docs: cdomain.py: add support for two new Sphinx 3.1+ tags

From: Mauro Carvalho Chehab
Date: Fri Sep 25 2020 - 00:40:50 EST


Em Thu, 24 Sep 2020 10:24:39 -0600
Jonathan Corbet <corbet@xxxxxxx> escreveu:

> On Thu, 24 Sep 2020 18:21:45 +0200
> Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx> wrote:
>
> > As part of changing the documentation subsystem to properly
> > build with Sphinx 3.1+, add support for two tags:
> >
> > - :c:expr:`foo`
> > - .. c:namespace::"
>
> So is there a reason we need :c:expr: ? What does it add for us?

Good point. This came from a suggestion from the Sphinx issue.

The :c:expr: actually helped to identify two wrong declarations at the
DVB uAPI docs[1] but in practice it doesn't do much, except
by using a different font like placing "struct" in italics.

I was expecting it to also create cross-references to the structs
mentioned there, but, at least on my tests, it didn't work like that.

Anyway, I guess we can just get rid of it.

I'll send a v3 series without that.

Thanks,
Mauro