Re: [PATCH] drm/vc4: Deleted the drm_device declaration

[tiantao (H)]

Hi :
I alwaygs used scripts/get_maintainers.pl to get the recipient list.I 
don't know why miss maintainers for a given piece of code.

tiantao@ubuntu:~$ git send-email -to eric@xxxxxxxxxx -to 
airlied@xxxxxxxx -to daniel@xxxxxxxx -to sumit.semwal@xxxxxxxxxx -to 
christian.koenig@xxxxxxx -to dri-devel@xxxxxxxxxxxxxxxxxxxxx -to 
linux-kernel@xxxxxxxxxxxxxxx -to linux-media@xxxxxxxxxxxxxxx -to 
linaro-mm-sig@xxxxxxxxxxxxxxxx 
mailline/drm/drm/0001-drm-vc4-Deleted-the-drm_device-declaration.patch 
--suppress-cc=all
mailline/drm/drm/0001-drm-vc4-Deleted-the-drm_device-declaration.patch

tiantao@ubuntu:~/mailline/drm/drm$ vim drivers/gpu/drm/vc4/vc4_drv.h^C
tiantao@ubuntu:~/mailline/drm/drm$ ./scripts/get_maintainer.pl 
drivers/gpu/drm/vc4/vc4_drv.h
Eric Anholt <eric@xxxxxxxxxx> (supporter:DRM DRIVERS FOR VC4)
David Airlie <airlied@xxxxxxxx> (maintainer:DRM DRIVERS)
Daniel Vetter <daniel@xxxxxxxx> (maintainer:DRM DRIVERS)
Sumit Semwal <sumit.semwal@xxxxxxxxxx> (maintainer:DMA BUFFER SHARING 
FRAMEWORK)
"Christian König" <christian.koenig@xxxxxxx> (maintainer:DMA BUFFER 
SHARING FRAMEWORK)
dri-devel@xxxxxxxxxxxxxxxxxxxxx (open list:DRM DRIVERS)
linux-kernel@xxxxxxxxxxxxxxx (open list)
linux-media@xxxxxxxxxxxxxxx (open list:DMA BUFFER SHARING FRAMEWORK)
linaro-mm-sig@xxxxxxxxxxxxxxxx (moderated list:DMA BUFFER SHARING FRAMEWORK)


在 2020/9/25 17:10, Daniel Vetter 写道:
> On Fri, Sep 25, 2020 at 04:51:38PM +0800, Tian Tao wrote:
> > drm_modeset_lock.h already declares struct drm_device, so there's no
> > need to declare it in vc4_drv.h
> >
> > Signed-off-by: Tian Tao <tiantao6@xxxxxxxxxxxxx>
>
> Just an aside, when submitting patches please use
> scripts/get_maintainers.pl to generate the recipient list. Looking through
> past few patches from you it seems fairly arbitrary and often misses the
> actual maintainers for a given piece of code, which increases the odds the
> patch will get lost a lot.
>
> E.g. for this one I'm only like the 5th or so fallback person, and the
> main maintainer isn't on the recipient list.
>
> Cheeers, Daniel
>
> > ---
> >   drivers/gpu/drm/vc4/vc4_drv.h | 1 -
> >   1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/vc4/vc4_drv.h b/drivers/gpu/drm/vc4/vc4_drv.h
> > index 8c8d96b..8717a1c 100644
> > --- a/drivers/gpu/drm/vc4/vc4_drv.h
> > +++ b/drivers/gpu/drm/vc4/vc4_drv.h
> > @@ -19,7 +19,6 @@
> >   
> >   #include "uapi/drm/vc4_drm.h"
> >   
> > -struct drm_device;
> >   struct drm_gem_object;
> >   
> >   /* Don't forget to update vc4_bo.c: bo_type_names[] when adding to
> > --
> > 2.7.4