Re: [PATCH] mtd: spi-nor: macronix: Add SECT_4K to mx25l12805d

[Robert Marko]

On Fri, Sep 25, 2020 at 1:27 PM Vignesh Raghavendra <vigneshr@xxxxxx> wrote:
>
> Hi,
>
> On 9/15/20 3:36 PM, Robert Marko wrote:
> > According to the mx25l12805d datasheet it supports using 4K or 64K sectors.
> > So lets add the SECT_4K to enable 4K sector usage.
> >
> > Datasheet: https://www.mxic.com.tw/Lists/Datasheet/Attachments/7321/MX25L12805D,%203V,%20128Mb,%20v1.2.pdf
>
> Have you tested this feature on a real HW?
Hi,
Yes, this has been tested on Alfa AP120C-AC which uses mx25l12805d.
I have not spotted any issues with it.

Regards,
Robert
>
> >
> > Signed-off-by: Robert Marko <robert.marko@xxxxxxxxxx>
> > Cc: Luka Perkov <luka.perkov@xxxxxxxxxx>
> > ---
> >  drivers/mtd/spi-nor/macronix.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/mtd/spi-nor/macronix.c b/drivers/mtd/spi-nor/macronix.c
> > index f97f3d127575..9203abaac229 100644
> > --- a/drivers/mtd/spi-nor/macronix.c
> > +++ b/drivers/mtd/spi-nor/macronix.c
> > @@ -50,7 +50,7 @@ static const struct flash_info macronix_parts[] = {
> >       { "mx25u4035",   INFO(0xc22533, 0, 64 * 1024,   8, SECT_4K) },
> >       { "mx25u8035",   INFO(0xc22534, 0, 64 * 1024,  16, SECT_4K) },
> >       { "mx25u6435f",  INFO(0xc22537, 0, 64 * 1024, 128, SECT_4K) },
> > -     { "mx25l12805d", INFO(0xc22018, 0, 64 * 1024, 256, 0) },
> > +     { "mx25l12805d", INFO(0xc22018, 0, 64 * 1024, 256, SECT_4K) },
> >       { "mx25l12855e", INFO(0xc22618, 0, 64 * 1024, 256, 0) },
> >       { "mx25r1635f",  INFO(0xc22815, 0, 64 * 1024,  32,
> >                             SECT_4K | SPI_NOR_DUAL_READ |
> >
>
> Regards
> Vignesh