Re: [PATCH v1 2/2] regulator: rtmv20: Add DT-binding document for Richtek RTMV20

[ChiYuan Huang]

Re-add into the mail loop list.

ChiYuan Huang <u0084500@xxxxxxxxx> 於 2020年9月25日 週五 下午12:09寫道：
>
> Mark Brown <broonie@xxxxxxxxxx> 於 2020年9月25日 週五 上午12:24寫道：
> >
> > On Thu, Sep 24, 2020 at 11:04:51PM +0800, cy_huang wrote:
> >
> > > +  enable-gpio:
> > > +    description: A connection of the 'enable' gpio line.
> > > +    maxItems: 1
> >
> > -gpios.  GPIO properties should always be plural even if there's only
> > one GPIO.
> >
> > > +  ld_pulse_delay:
> >
> > Properties should use - not _ and for all the properties specifying
> > things like times you should have units so...
> >
> > > +    description: |
> > > +      load current pulse delay in microsecond after strobe pin pulse high.
> > > +    $ref: "/schemas/types.yaml#/definitions/uint32"
> >
> > ...add -us here.
> >
> Ack
> > > +  fsin_enable:
> > > +    description: Fsin function enable control.
> > > +    $ref: "/schemas/types.yaml#/definitions/uint32"
> > > +    minimum: 0
> > > +    maximum: 1
> > > +    default: 0
> >
> > This looks like it should be a boolean property not a number.  The same
> > is true for most if not all of the other properties with min/max of 0/1.
> Ok, just change the property as boolean type.