Re: [PATCH 6/6] USB: cdc-acm: blacklist ETAS ES58X device
From: Greg Kroah-Hartman
Date: Sun Sep 27 2020 - 01:52:38 EST
On Sun, Sep 27, 2020 at 07:45:20AM +0200, Greg Kroah-Hartman wrote:
> On Sun, Sep 27, 2020 at 02:57:56AM +0900, Vincent Mailhol wrote:
> > The ES58X devices are incorrectly recognized as USB Modem (CDC ACM),
> > preventing the etas-es58x module to load.
> >
> > Thus, these have been added
> > to the ignore list in drivers/usb/class/cdc-acm.c
> >
> > Signed-off-by: Vincent Mailhol <mailhol.vincent@xxxxxxxxxx>
> > ---
> > drivers/usb/class/cdc-acm.c | 11 +++++++++++
> > 1 file changed, 11 insertions(+)
>
> Did you mean to send this twice?
>
> And where are the 5 other patches in this series?
>
> And finally, it's a good idea to include the output of 'lsusb -v' for
> devices that need quirks so we can figure things out later on, can you
> fix up your changelog to include that information?
Also, why is the device saying it is a cdc-acm compliant device when it
is not? Why lie to the operating system like that?
thanks,
greg k-h