Re: [PATCH] rcu: Clarify nocb kthreads naming in RCU_NOCB_CPU config

From: Joel Fernandes
Date: Sun Sep 27 2020 - 20:13:52 EST


On Thu, Sep 24, 2020 at 12:04:10PM +0530, Neeraj Upadhyay wrote:
> Clarify the "x" in rcuox/N naming in RCU_NOCB_CPU config
> description.
>

Reviewed-by: Joel Fernandes (Google) <joel@xxxxxxxxxxxxxxxxx>

thanks,

- Joel

> Signed-off-by: Neeraj Upadhyay <neeraju@xxxxxxxxxxxxxx>
> ---
> kernel/rcu/Kconfig | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/kernel/rcu/Kconfig b/kernel/rcu/Kconfig
> index b71e21f..5b22747 100644
> --- a/kernel/rcu/Kconfig
> +++ b/kernel/rcu/Kconfig
> @@ -227,11 +227,12 @@ config RCU_NOCB_CPU
> specified at boot time by the rcu_nocbs parameter. For each
> such CPU, a kthread ("rcuox/N") will be created to invoke
> callbacks, where the "N" is the CPU being offloaded, and where
> - the "p" for RCU-preempt (PREEMPTION kernels) and "s" for RCU-sched
> - (!PREEMPTION kernels). Nothing prevents this kthread from running
> - on the specified CPUs, but (1) the kthreads may be preempted
> - between each callback, and (2) affinity or cgroups can be used
> - to force the kthreads to run on whatever set of CPUs is desired.
> + the "x" is "p" for RCU-preempt (PREEMPTION kernels) and "s" for
> + RCU-sched (!PREEMPTION kernels). Nothing prevents this kthread
> + from running on the specified CPUs, but (1) the kthreads may be
> + preempted between each callback, and (2) affinity or cgroups can
> + be used to force the kthreads to run on whatever set of CPUs is
> + desired.
>
> Say Y here if you want to help to debug reduced OS jitter.
> Say N here if you are unsure.
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>