Re: [PATCH v4 02/17] x86/acrn: Introduce acrn_{setup, remove}_intr_handler()

[Shuo A Liu]

On Sun 27.Sep'20 at 12:49:43 +0200, Greg Kroah-Hartman wrote:
> On Tue, Sep 22, 2020 at 07:42:56PM +0800, shuo.a.liu@xxxxxxxxx wrote:
> > From: Shuo Liu <shuo.a.liu@xxxxxxxxx>
> >
> > The ACRN Hypervisor builds an I/O request when a trapped I/O access
> > happens in User VM. Then, ACRN Hypervisor issues an upcall by sending
> > a notification interrupt to the Service VM. HSM in the Service VM needs
> > to hook the notification interrupt to handle I/O requests.
> >
> > Notification interrupts from ACRN Hypervisor are already supported and
> > a, currently uninitialized, callback called.
> >
> > Export two APIs for HSM to setup/remove its callback.
> >
> > Originally-by: Yakui Zhao <yakui.zhao@xxxxxxxxx>
> > Signed-off-by: Shuo Liu <shuo.a.liu@xxxxxxxxx>
> > Reviewed-by: Zhi Wang <zhi.a.wang@xxxxxxxxx>
> > Reviewed-by: Reinette Chatre <reinette.chatre@xxxxxxxxx>
> > Cc: Dave Hansen <dave.hansen@xxxxxxxxx>
> > Cc: Sean Christopherson <sean.j.christopherson@xxxxxxxxx>
> > Cc: Dan Williams <dan.j.williams@xxxxxxxxx>
> > Cc: Fengwei Yin <fengwei.yin@xxxxxxxxx>
> > Cc: Zhi Wang <zhi.a.wang@xxxxxxxxx>
> > Cc: Zhenyu Wang <zhenyuw@xxxxxxxxxxxxxxx>
> > Cc: Yu Wang <yu1.wang@xxxxxxxxx>
> > Cc: Reinette Chatre <reinette.chatre@xxxxxxxxx>
> > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > ---
> >  arch/x86/include/asm/acrn.h |  8 ++++++++
> >  arch/x86/kernel/cpu/acrn.c  | 16 ++++++++++++++++
> >  2 files changed, 24 insertions(+)
> >  create mode 100644 arch/x86/include/asm/acrn.h
> >
> > diff --git a/arch/x86/include/asm/acrn.h b/arch/x86/include/asm/acrn.h
> > new file mode 100644
> > index 000000000000..ff259b69cde7
> > --- /dev/null
> > +++ b/arch/x86/include/asm/acrn.h
> > @@ -0,0 +1,8 @@
> > +/* SPDX-License-Identifier: GPL-2.0 */
> > +#ifndef _ASM_X86_ACRN_H
> > +#define _ASM_X86_ACRN_H
> > +
> > +void acrn_setup_intr_handler(void (*handler)(void));
> > +void acrn_remove_intr_handler(void);
> > +
> > +#endif /* _ASM_X86_ACRN_H */
> > diff --git a/arch/x86/kernel/cpu/acrn.c b/arch/x86/kernel/cpu/acrn.c
> > index 0b2c03943ac6..42e88d01ccf9 100644
> > --- a/arch/x86/kernel/cpu/acrn.c
> > +++ b/arch/x86/kernel/cpu/acrn.c
> > @@ -9,7 +9,11 @@
> >   *
> >   */
> >
> > +#define pr_fmt(fmt) "acrn: " fmt
>
> Why is this needed, if you are not adding pr_* calls in this patch?

True. I will remove it. Thanks.