Re: [PATCH] ARM: davinci: fix kconfig dependency warning when !GPIOLIB

[Sekhar Nori]

On 14/09/20 7:49 PM, Necip Fazil Yildiran wrote:
> When MACH_DAVINCI_DA830_EVM is enabled and GPIOLIB is disabled, it results
> in the following Kbuild warning:
> 
> WARNING: unmet direct dependencies detected for GPIO_PCF857X
>   Depends on [n]: GPIOLIB [=n] && I2C [=y]
>   Selected by [y]:
>   - MACH_DAVINCI_DA830_EVM [=y] && ARCH_DAVINCI [=y] && ARCH_DAVINCI_DA830 [=y] && I2C [=y]
> 
> The reason is that MACH_DAVINCI_DA830_EVM selects GPIO_PCF857X without
> depending on or selecting GPIOLIB while GPIO_PCF857X is subordinate to
> GPIOLIB.
> 
> Honor the kconfig menu hierarchy to remove kconfig dependency warnings.
> 
> Fixes: 77316f057526 ("davinci: DA830/OMAP-L137 EVM: use runtime detection for UI card")
> Signed-off-by: Necip Fazil Yildiran <fazilyildiran@xxxxxxxxx>

Here too, I think changing to "imply GPIO_PCF857X if I2C" is better.

Thanks,
Sekhar