Re: [PATCH AUTOSEL 4.14 112/127] perf parse-events: Fix incorrect conversion of 'if () free()' to 'zfree()'

[Sasha Levin]

On Tue, Sep 29, 2020 at 01:24:32AM +0530, Naresh Kamboju wrote:
> On Fri, 18 Sep 2020 at 08:00, Sasha Levin <sashal@xxxxxxxxxx> wrote:
> > From: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
> >
> > [ Upstream commit 7fcdccd4237724931d9773d1e3039bfe053a6f52 ]
> >
> > When applying a patch by Ian I incorrectly converted to zfree() an
> > expression that involved testing some other struct member, not the one
> > being freed, which lead to bugs reproduceable by:
> >
> >   $ perf stat -e i/bs,tsc,L2/o sleep 1
> >   WARNING: multiple event parsing errors
> >   Segmentation fault (core dumped)
> >   $
> >
> > Fix it by restoring the test for pos->free_str before freeing
> > pos->val.str, but continue using zfree(&pos->val.str) to set that member
> > to NULL after freeing it.
> >
> > Reported-by: Ian Rogers <irogers@xxxxxxxxxx>
> > Fixes: e8dfb81838b1 ("perf parse-events: Fix memory leaks found on parse_events")
> > Cc: Adrian Hunter <adrian.hunter@xxxxxxxxx>
> > Cc: Alexander Shishkin <alexander.shishkin@xxxxxxxxxxxxxxx>
> > Cc: Andi Kleen <ak@xxxxxxxxxxxxxxx>
> > Cc: clang-built-linux@xxxxxxxxxxxxxxxx
> > Cc: Jiri Olsa <jolsa@xxxxxxxxxx>
> > Cc: Leo Yan <leo.yan@xxxxxxxxxx>
> > Cc: Mark Rutland <mark.rutland@xxxxxxx>
> > Cc: Namhyung Kim <namhyung@xxxxxxxxxx>
> > Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> > Cc: Stephane Eranian <eranian@xxxxxxxxxx>
> > Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
> > Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
>
> stable rc 4.14 perf build broken.

Dropped, thanks!

--
Thanks,
Sasha