Re: [PATCH 4.19 38/92] kprobes: Fix NULL pointer dereference at kprobe_ftrace_handler

[Steven Rostedt]

On Mon, 28 Sep 2020 18:09:42 -0400
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> On Tue, 29 Sep 2020 01:32:59 +0530
> Naresh Kamboju <naresh.kamboju@xxxxxxxxxx> wrote:
> 
> > stable rc branch 4.19 build warning on arm64.
> > 
> > ../kernel/kprobes.c: In function ‘kill_kprobe’:
> > ../kernel/kprobes.c:1070:33: warning: statement with no effect [-Wunused-value]
> >  1070 | #define disarm_kprobe_ftrace(p) (-ENODEV)
> >       |                                 ^
> > ../kernel/kprobes.c:2090:3: note: in expansion of macro ‘disarm_kprobe_ftrace’
> >  2090 |   disarm_kprobe_ftrace(p);
> >       |   ^~~~~~~~~~~~~~~~~~~~  
> 
> Seems to affect upstream as well.
> 

Bah, no (tested the wrong kernel).

You want this commit too:

10de795a5addd ("kprobes: Fix compiler warning for !CONFIG_KPROBES_ON_FTRACE")

-- Steve