Re: [PATCH AUTOSEL 4.4 42/64] serial: uartps: Wait for tx_empty in console setup

[Sasha Levin]

On Tue, Sep 29, 2020 at 01:46:59AM +0530, Naresh Kamboju wrote:
> On Fri, 18 Sep 2020 at 07:51, Sasha Levin <sashal@xxxxxxxxxx> wrote:
> > From: Raviteja Narayanam <raviteja.narayanam@xxxxxxxxxx>
> >
> > [ Upstream commit 42e11948ddf68b9f799cad8c0ddeab0a39da33e8 ]
> >
> > On some platforms, the log is corrupted while console is being
> > registered. It is observed that when set_termios is called, there
> > are still some bytes in the FIFO to be transmitted.
> >
> > So, wait for tx_empty inside cdns_uart_console_setup before calling
> > set_termios.
> >
> > Signed-off-by: Raviteja Narayanam <raviteja.narayanam@xxxxxxxxxx>
> > Reviewed-by: Shubhrajyoti Datta <shubhrajyoti.datta@xxxxxxxxxx>
> > Link: https://lore.kernel.org/r/1586413563-29125-2-git-send-email-raviteja.narayanam@xxxxxxxxxx
> > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
>
> stable rc branch 4.4 arm64 build broken.
>
> ../drivers/tty/serial/xilinx_uartps.c: In function ‘cdns_uart_console_setup’:
> ../drivers/tty/serial/xilinx_uartps.c:1170:40: error: ‘TX_TIMEOUT’
> undeclared (first use in this function)
> 1170 |  time_out = jiffies + usecs_to_jiffies(TX_TIMEOUT);
>                                                                      ^~~~~~~~~~
> Reported-by: Naresh Kamboju <naresh.kamboju@xxxxxxxxxx>

Dropped, thanks!

--
Thanks,
Sasha