Re: [PATCH] iommu/qcom: add missing put_device() call in qcom_iommu_of_xlate()

[yukuai (C)]

On 2020/09/29 7:08, Will Deacon wrote:
> On Mon, Sep 21, 2020 at 09:45:57PM +0100, Will Deacon wrote:
> > On Tue, Sep 22, 2020 at 03:13:53AM +0800, kernel test robot wrote:
> > > Thank you for the patch! Perhaps something to improve:
> > >
> > > [auto build test WARNING on iommu/next]
> > > [also build test WARNING on linus/master v5.9-rc6 next-20200921]
> > > [cannot apply to robclark/msm-next]
> > > [If your patch is applied to the wrong git tree, kindly drop us a note.
> > > And when submitting patch, we suggest to use '--base' as documented in
> > > https://git-scm.com/docs/git-format-patch]
> > >
> > > url:    https://github.com/0day-ci/linux/commits/Yu-Kuai/iommu-qcom-add-missing-put_device-call-in-qcom_iommu_of_xlate/20200918-091341
> > > base:   https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git next
> > > config: arm64-randconfig-r023-20200920 (attached as .config)
> > > compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 4e8c028158b56d9c2142a62464e8e0686bde3584)
> > > reproduce (this is a W=1 build):
> > >          wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > >          chmod +x ~/bin/make.cross
> > >          # install arm64 cross compiling tool for clang build
> > >          # apt-get install binutils-aarch64-linux-gnu
> > >          # save the attached .config to linux build tree
> > >          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64
> > >
> > > If you fix the issue, kindly add following tag as appropriate
> > > Reported-by: kernel test robot <lkp@xxxxxxxxx>
> > >
> > > All warnings (new ones prefixed by >>):
> > >
> > > > > drivers/iommu/arm/arm-smmu/qcom_iommu.c:601:4: warning: misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation]
> > >                             return -EINVAL;
> > >                             ^
> > >     drivers/iommu/arm/arm-smmu/qcom_iommu.c:599:3: note: previous statement is here
> > >                     if (WARN_ON(qcom_iommu != dev_iommu_priv_get(dev)))
> >
> > Oh, this looks like a nasty bug. Seems we're missing some braces.
>
> Yu Kuai: please could you send a v2 of this?

Hi, Will

Thanks for your notice, will send a V2 soon.

Yu Kuai