Re: [PATCH] ubifs: journal: Make sure to not dirty twice for auth nodes

[Richard Weinberger]

----- Ursprüngliche Mail -----
> Von: "Sascha Hauer" <s.hauer@xxxxxxxxxxxxxx>
> An: "richard" <richard@xxxxxx>
> CC: "linux-mtd" <linux-mtd@xxxxxxxxxxxxxxxxxxx>, "linux-kernel" <linux-kernel@xxxxxxxxxxxxxxx>, "stable"
> <stable@xxxxxxxxxxxxxxx>, "Kristof Havasi" <havasiefr@xxxxxxxxx>
> Gesendet: Dienstag, 29. September 2020 10:32:32
> Betreff: Re: [PATCH] ubifs: journal: Make sure to not dirty twice for auth nodes

> On Mon, Sep 28, 2020 at 09:06:12PM +0200, Richard Weinberger wrote:
>> When removing the last reference of an inode the size of an auth node
>> is already part of write_len. So we must not call ubifs_add_auth_dirt().
>> Call it only when needed.
>> 
>> Cc: <stable@xxxxxxxxxxxxxxx>
>> Cc: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
>> Cc: Kristof Havasi <havasiefr@xxxxxxxxx>
>> Fixes: 6a98bc4614de ("ubifs: Add authentication nodes to journal")
>> Reported-by: Kristof Havasi <havasiefr@xxxxxxxxx>
>> Signed-off-by: Richard Weinberger <richard@xxxxxx>
> 
> Looked at the code until I understood what the problem is and how it is
> fixed, so:
> 
> Reviewed-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>

Applied to fixes branch!

Thanks,
//richard