Re: [PATCH v10 00/20] gpio: cdev: add uAPI v2

From: Andy Shevchenko
Date: Tue Sep 29 2020 - 12:22:33 EST


On Tue, Sep 29, 2020 at 6:13 PM Bartosz Golaszewski
<bgolaszewski@xxxxxxxxxxxx> wrote:
>
> On Mon, Sep 28, 2020 at 2:28 AM Kent Gibson <warthog618@xxxxxxxxx> wrote:
> >
> > This patchset defines and implements a new version of the
> > GPIO CDEV uAPI to address existing 32/64-bit alignment issues, add
> > support for debounce, event sequence numbers, and allow for requested
> > lines with different configurations.
> > It provides some future proofing by adding optional configuration fields
> > and padding reserved for future use.
> >
> > The series can be partitioned into three blocks; the first two patches
> > are minor fixes that impact later patches, the next eleven contain the
> > v2 uAPI definition and implementation, and the final seven port the GPIO
> > tools to the v2 uAPI and extend them to use new uAPI features.
> >
> > The more complicated patches include their own commentary where
> > appropriate.

> This series looks great now. Unless there are new objections I intend
> on picking it up tomorrow.

Various nit-picks, if any, can be addressed later on.

--
With Best Regards,
Andy Shevchenko