Re: [PATCH AUTOSEL 4.9 64/90] serial: uartps: Wait for tx_empty in console setup

[Sasha Levin]

On Tue, Sep 29, 2020 at 08:59:02AM +0200, Greg Kroah-Hartman wrote:
> On Tue, Sep 29, 2020 at 01:43:22AM +0530, Naresh Kamboju wrote:
> > On Tue, 29 Sep 2020 at 01:41, Naresh Kamboju <naresh.kamboju@xxxxxxxxxx> wrote:
> > >
> > > On Fri, 18 Sep 2020 at 07:55, Sasha Levin <sashal@xxxxxxxxxx> wrote:
> > > >
> > > > From: Raviteja Narayanam <raviteja.narayanam@xxxxxxxxxx>
> > > >
> > > > [ Upstream commit 42e11948ddf68b9f799cad8c0ddeab0a39da33e8 ]
> > > >
> > > > On some platforms, the log is corrupted while console is being
> > > > registered. It is observed that when set_termios is called, there
> > > > are still some bytes in the FIFO to be transmitted.
> > > >
> > > > So, wait for tx_empty inside cdns_uart_console_setup before calling
> > > > set_termios.
> > > >
> > > > Signed-off-by: Raviteja Narayanam <raviteja.narayanam@xxxxxxxxxx>
> > > > Reviewed-by: Shubhrajyoti Datta <shubhrajyoti.datta@xxxxxxxxxx>
> > > > Link: https://lore.kernel.org/r/1586413563-29125-2-git-send-email-raviteja.narayanam@xxxxxxxxxx
> > > > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > > > Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
> > >
> > > stable rc 4.9 arm64 build broken.
> >
> > and stable rc 4.9 arm build broken.
>
> Thanks, I've queued up the dependant patch, somehow Sasha's builders
> must have missed this :)

Because it doesn't fail here with an allmodconfig :(

sasha@sasha-builder:~/data/linux$ git checkout queue-4.9
HEAD is now at 77d58b1b4d54 kprobes: Fix to check probe enabled before disarm_kprobe_ftrace()
sasha@sasha-builder:~/data/linux$ make ARCH=arm64 CROSS_COMPILE="/home/sasha/x-tools/aarch64-unknown-linux-android/bin/aarch64-unknown-linux-android-" allmodconfig
scripts/kconfig/conf  --allmodconfig Kconfig
#
# configuration written to .config
#
sasha@sasha-builder:~/data/linux$ make ARCH=arm64 CROSS_COMPILE="/home/sasha/x-tools/aarch64-unknown-linux-gnu/bin/aarch64-unknown-linux-gnu-" drivers/tty/serial/xilinx_uartps.o
  CHK     include/config/kernel.release
  CHK     include/generated/uapi/linux/version.h
  CHK     include/generated/utsrelease.h
  CHK     include/generated/bounds.h
  CHK     include/generated/timeconst.h
  CHK     include/generated/asm-offsets.h
  CALL    scripts/checksyscalls.sh
  CHK     scripts/mod/devicetable-offsets.h
  CC [M]  drivers/tty/serial/xilinx_uartps.o

--
Thanks,
Sasha