Re: [PATCH v8 12/32] i2c: tegra: Use clk-bulk helpers
From: Dmitry Osipenko
Date: Tue Sep 29 2020 - 17:01:53 EST
29.09.2020 22:33, Wolfram Sang пишет:
> On Wed, Sep 23, 2020 at 01:51:35AM +0300, Dmitry Osipenko wrote:
>> Use clk-bulk helpers and factor out clocks initialization into separate
>> function in order to make code cleaner.
>>
>> The clocks initialization now performed after reset-control initialization
>> in order to avoid a noisy -PROBE_DEFER errors on T186+ from the clk-bulk
>> helper which doesn't silence this error code. Hence reset_control_get()
>> now may return -EPROBE_DEFER on newer Tegra SoCs because they use BPMP
>> driver that provides reset controls and BPMP doesn't come up early during
>> boot. Previously rst was protected by the clocks retrieval and now this
>> patch makes dev_err_probe() to be used for the rst error handling.
>>
>> Suggested-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
>> Signed-off-by: Dmitry Osipenko <digetx@xxxxxxxxx>
>
> Any comments here? I'll apply this series later this week if there are
> no objections coming up.
>
Please hold on, I just spotted a serious problem in patch 23 and v9
needs to be done.