Re: [PATCH v4 1/2] dt-bindings: leds: Add bindings for MT6360 LED

[Gene Chen]

Rob Herring <robh@xxxxxxxxxx> 於 2020年9月29日 週二 上午2:44寫道：
>
> On Wed, Sep 23, 2020 at 08:50:51PM +0800, Gene Chen wrote:
> > From: Gene Chen <gene_chen@xxxxxxxxxxx>
> >
> > Add bindings document for LED support on MT6360 PMIC
> >
> > Signed-off-by: Gene Chen <gene_chen@xxxxxxxxxxx>
> > ---
> >  .../devicetree/bindings/leds/leds-mt6360.yaml      | 107 +++++++++++++++++++++
> >  1 file changed, 107 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/leds/leds-mt6360.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/leds/leds-mt6360.yaml b/Documentation/devicetree/bindings/leds/leds-mt6360.yaml
> > new file mode 100644
> > index 0000000..a356a1f
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/leds/leds-mt6360.yaml
> > @@ -0,0 +1,107 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/leds/leds-mt6360.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: LED driver for MT6360 PMIC from MediaTek Integrated.
>
> Where's the PMIC schema? This file needs to be referenced from it and
> that means it all needs to be one series.
>

Do you means as regulator/max77650-regulator.yaml?

description: |
  This module is part of the MAX77650 MFD device. For more details
  "see Documentation/devicetree/bindings/mfd/max77650.yaml"

> > +
> > +maintainers:
> > +  - Gene Chen <gene_chen@xxxxxxxxxxx>
> > +
> > +description: |
> > +  This module is part of the MT6360 MFD device.
> > +  Add MT6360 LED driver include 2-channel Flash LED with torch/strobe mode,
> > +  and 4-channel RGB LED support Register/Flash/Breath Mode
> > +
> > +properties:
> > +  compatible:
> > +    const: mediatek,mt6360-led
> > +
> > +  "#address-cells":
> > +    const: 1
> > +
> > +  "#size-cells":
> > +    const: 0
> > +
> > +patternProperties:
> > +  "^led@[0-5]$":
> > +    type: object
> > +    $ref: common.yaml#
> > +    description:
> > +      Properties for a single LED.
> > +
> > +    properties:
> > +      reg:
> > +        description: Index of the LED.
> > +        enum:
> > +          - 0 # LED output INDICATOR1
> > +          - 1 # LED output INDICATOR2
> > +          - 2 # LED output INDICATOR3
> > +          - 3 # LED output INDICATOR4
> > +          - 4 # LED output FLED1
> > +          - 5 # LED output FLED2
> > +
> > +unevaluatedProperties: false
> > +
> > +required:
> > +  - compatible
> > +  - "#address-cells"
> > +  - "#size-cells"
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > +   #include <dt-bindings/leds/common.h>
> > +   led-controller {
> > +     compatible = "mediatek,mt6360-led";
> > +     #address-cells = <1>;
> > +     #size-cells = <0>;
> > +
> > +     led@0 {
> > +       reg = <0>;
> > +       function = LED_FUNCTION_INDICATOR;
> > +       color = <LED_COLOR_ID_RED>;
> > +       default-state = "off";
> > +     };
> > +     led@1 {
> > +       reg = <1>;
> > +       function = LED_FUNCTION_INDICATOR;
> > +       color = <LED_COLOR_ID_GREEN>;
> > +       default-state = "off";
> > +     };
> > +     led@2 {
> > +       reg = <2>;
> > +       function = LED_FUNCTION_INDICATOR;
> > +       color = <LED_COLOR_ID_BLUE>;
> > +       default-state = "off";
> > +     };
> > +     led@3 {
> > +       reg = <3>;
> > +       function = LED_FUNCTION_INDICATOR;
> > +       color = <LED_COLOR_ID_AMBER>;
> > +       default-state = "off";
> > +     };
> > +     led@4 {
> > +       reg = <4>;
> > +       function = LED_FUNCTION_FLASH;
> > +       color = <LED_COLOR_ID_WHITE>;
> > +       function-enumerator = <1>;
> > +       default-state = "off";
> > +       led-max-microamp = <200000>;
> > +       flash-max-microamp = <500000>;
> > +       flash-max-timeout-us = <1024000>;
> > +     };
> > +     led@5 {
> > +       reg = <5>;
> > +       function = LED_FUNCTION_FLASH;
> > +       color = <LED_COLOR_ID_WHITE>;
> > +       function-enumerator = <2>;
> > +       default-state = "off";
> > +       led-max-microamp = <200000>;
> > +       flash-max-microamp = <500000>;
> > +       flash-max-timeout-us = <1024000>;
> > +     };
> > +   };
> > +...
> > --
> > 2.7.4
> >