Re: [PATCH printk 3/5] printk: use buffer pool for sprint buffers

From: John Ogness
Date: Wed Sep 30 2020 - 04:57:17 EST


On 2020-09-30, Petr Mladek <pmladek@xxxxxxxx> wrote:
>> Doubling the cost of every single printk by unconditionally doing
>> vsnprintf() twice is a bad idea.
>
> I would prefer to solve this when there are real life problems.
> printk() should not get called in performance sensitive paths in
> the first place.
>
> We could always make the code more complicated when it can be
> justified. Extra buffers is yet another layer (code and memory)
> in the processing. And the current arguments sounds theoretical.

I am preparing a v2 that avoids the memory pool.

John Ogness