Re: [PATCH bpf-next v2 4/4] selftest: bpf: Test copying a sockmap and sockhash

From: Lorenz Bauer
Date: Wed Sep 30 2020 - 05:38:08 EST


On Tue, 29 Sep 2020 at 18:23, Martin KaFai Lau <kafai@xxxxxx> wrote:

...

> > Yeah, I think so. We'd need to do something similar to your
> > sock_common work for PTR_TO_RDONLY_BUF_OR_NULL. The fact that the
> > pointer is read only makes it a bit more difficult I think. After
> I thought the key arg should be used as read-only in the map's helper.
> or there is map type's helper that modifies the key?

I don't know, that's what I meant by more difficult. If map keys are
always read-only like you say this would be straight forward to do
(famous last words).

--
Lorenz Bauer | Systems Engineer
6th Floor, County Hall/The Riverside Building, SE1 7PB, UK

www.cloudflare.com