Re: [PATCH v2 12/12] mm/filemap: Return only head pages from find_get_entries

[Matthew Wilcox]

On Wed, Sep 30, 2020 at 02:15:12PM +0200, Jan Kara wrote:
> On Mon 14-09-20 14:00:42, Matthew Wilcox (Oracle) wrote:
> > All callers now expect head (and base) pages, and can handle multiple
> > head pages in a single batch, so make find_get_entries() behave that way.
> > Also take the opportunity to make it use the pagevec infrastructure
> > instead of open-coding how pvecs behave.  This has the side-effect of
> > being able to append to a pagevec with existing contents, although we
> > don't make use of that functionality anywhere yet.
> > 
> > Signed-off-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx>
> 
> Looks good to me. You can add:
> 
> Reviewed-by: Jan Kara <jack@xxxxxxx>
> 
> I'm just curious: What has happened to pagevec_lookup_entries() call in
> invalidate_inode_pages2_range()? Your series appears to be based on a tree
> where the call already does not exist...

That went away in patch 10 of this series.