Re: [PATCH 4.19 000/244] 4.19.149-rc2 review

[Guenter Roeck]

On Wed, Sep 30, 2020 at 09:26:48PM +0530, Naresh Kamboju wrote:
> On Tue, 29 Sep 2020 at 19:59, Greg Kroah-Hartman
> <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> >
> > This is the start of the stable review cycle for the 4.19.149 release.
> > There are 244 patches in this series, all will be posted as a response
> > to this one.  If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Thu, 01 Oct 2020 14:27:43 +0000.
> > Anything received after that time might be too late.
> >
> > The whole patch series can be found in one patch at:
> >         https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.149-rc2.gz
> > or in the git tree and branch at:
> >         git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
> > and the diffstat can be found below.
> >
> > thanks,
> >
> > greg k-h
> >
> 
> Results from Linaro’s test farm.
> No regressions on arm64, arm, x86_64, and i386.
> 
No perf build failure ? I just tried again, with a simple

make defconfig
make tools/perf

on my test system, and it fails to build reliably with

util/evsel.c: In function ‘perf_evsel__exit’:
util/util.h:25:28: error: passing argument 1 of ‘free’ discards ‘const’ qualifier from pointer target type

as reported. The culprit is commit d22b67e7dae9 ("perf parse-events: Fix 3
use after frees found with clang ASAN"). That is not a problem upstream because
of commit 7f7c536f23e6af ("tools lib: Adopt zalloc()/zfree() from tools/perf"),
but that is just hiding a problem with commit d22b67e7dae9 (which assigns a
pointer allocated with strdup() to a const * and then frees that const *). 

Anyway, how comes that only I seem to see that problem ?

Guenter