Re: [PATCH v2] pipe: Fix memory leaks in create_pipe_files()

From: Eric Biggers
Date: Wed Sep 30 2020 - 23:04:35 EST


On Wed, Sep 30, 2020 at 10:52:55PM -0400, Qian Cai wrote:
> diff --git a/include/linux/watch_queue.h b/include/linux/watch_queue.h
> index 5e08db2adc31..20665fbe0552 100644
> --- a/include/linux/watch_queue.h
> +++ b/include/linux/watch_queue.h
> @@ -123,5 +123,9 @@ static inline void remove_watch_list(struct watch_list *wlist, u64 id)
> #define watch_sizeof(STRUCT) (sizeof(STRUCT) << WATCH_INFO_LENGTH__SHIFT)
>
> #endif
> +static inline int watch_queue_init(struct pipe_inode_info *pipe)
> +{
> + return -ENOPKG;
> +}

This needs to be conditional on !CONFIG_WATCH_QUEUE.

- Eric