Re: [PATCH v2] pinctrl: mediatek: Free eint data on failure

[Linus Walleij]

On Wed, Sep 30, 2020 at 6:33 PM Sean Wang <sean.wang@xxxxxxxxxx> wrote:
> On Wed, Sep 30, 2020 at 1:47 AM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> > On Sun, Sep 27, 2020 at 7:57 PM Sean Wang <sean.wang@xxxxxxxxxx> wrote:
> >
> > > v2 seems the same with v1 or I was missing something.
> > >
> > > I just thought we call devm_ioremap_release to explicitly to free
> > > resource when a certain failure occurs after
> > > devm_ioremap_resource?
> >
> > What is the semantics around mtk_build_eint()?
> >
>
> mtk_build_eint is to add external interrupt function to the
> corresponding bound pins.
> mtk pinctrl driver still can work (than means probe() successfully) to
> keep pinctrl functional even with there is an error in mtk_build_eint.
> So the patch is used to explicitly free those data on failure in
> mtk_build_eint to let unused data is being free:ed immediately.

OK then we need a v3 of this that will call *release
explicitly, indeed.

Thanks Sean!
Linus Walleij