Re: [PATCH v14 01/15] mtd: spi-nor: core: use EOPNOTSUPP instead of ENOTSUPP

[Vignesh Raghavendra]

Hi,

On 10/1/20 1:20 PM, Miquel Raynal wrote:
> Hello,
> 
> Pratyush Yadav <p.yadav@xxxxxx> wrote on Thu, 1 Oct 2020 13:04:27 +0530:
> 
>> On 01/10/20 07:19AM, Tudor.Ambarus@xxxxxxxxxxxxx wrote:
>>> On 9/30/20 9:57 PM, Pratyush Yadav wrote:  
>>>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> It seems that your mailer/server introduced that line automatically,
> can you do something to avoid it?
> 
>>>>
>>>> ENOTSUPP is not a SUSV4 error code. Using EOPNOTSUPP is preferred
>>>> in its stead.
> 
> I ran into this checkpatch.pl error recently, I count 80+ iterations in
> drivers/mtd/ so perhaps having a subsystem wide replacement will be
> nice. I'm fine with this patch though as it is addressing all SPI-NOR
> cases already.
> 

Yeah, since this is SPI NOR wide I will go ahead and apply.
Also, this would avoid confusion for ppl adding new code on whether to
address the checkpatch warning or follow the existing convention.

Regards
Vignesh

> Cheers,
> Miquèl
> 

[...]