Re: [PATCH v6 1/3] media: i2c: ov772x: Parse endpoint properties

[Sakari Ailus]

On Wed, Sep 30, 2020 at 01:19:40PM +0100, Lad, Prabhakar wrote:
> HI Sakari,
> 
> Thank you for the review.
> 
> On Wed, Sep 30, 2020 at 12:45 PM Sakari Ailus
> <sakari.ailus@xxxxxxxxxxxxxxx> wrote:
> >
> > Hi Prabhakar,
> >
> > On Thu, Sep 17, 2020 at 06:42:22PM +0100, Lad Prabhakar wrote:
> > > Parse endpoint properties using v4l2_fwnode_endpoint_alloc_parse()
> > > to determine the bus type and store it in the driver structure.
> > >
> > > Set bus_type to V4L2_MBUS_PARALLEL as it's the only supported one
> > >
> > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> > > ---
> > >  drivers/media/i2c/ov772x.c | 34 ++++++++++++++++++++++++++++++++++
> > >  1 file changed, 34 insertions(+)
> > >
> > > diff --git a/drivers/media/i2c/ov772x.c b/drivers/media/i2c/ov772x.c
> > > index 2cc6a678069a..f61a3f09ad64 100644
> > > --- a/drivers/media/i2c/ov772x.c
> > > +++ b/drivers/media/i2c/ov772x.c
> > > @@ -31,6 +31,7 @@
> > >  #include <media/v4l2-ctrls.h>
> > >  #include <media/v4l2-device.h>
> > >  #include <media/v4l2-event.h>
> > > +#include <media/v4l2-fwnode.h>
> > >  #include <media/v4l2-image-sizes.h>
> > >  #include <media/v4l2-subdev.h>
> > >
> > > @@ -434,6 +435,7 @@ struct ov772x_priv {
> > >  #ifdef CONFIG_MEDIA_CONTROLLER
> > >       struct media_pad pad;
> > >  #endif
> > > +     enum v4l2_mbus_type               bus_type;
> > >  };
> > >
> > >  /*
> > > @@ -1348,6 +1350,34 @@ static const struct v4l2_subdev_ops ov772x_subdev_ops = {
> > >       .pad    = &ov772x_subdev_pad_ops,
> > >  };
> > >
> > > +static int ov772x_parse_dt(struct i2c_client *client,
> > > +                        struct ov772x_priv *priv)
> > > +{
> > > +     struct v4l2_fwnode_endpoint bus_cfg;
> > > +     struct fwnode_handle *ep;
> > > +     int ret;
> > > +
> > > +     ep = fwnode_graph_get_next_endpoint(dev_fwnode(&client->dev),
> > > +                                         NULL);
> > > +     if (!ep) {
> > > +             dev_err(&client->dev, "Endpoint node not found\n");
> > > +             return -EINVAL;
> > > +     }
> > > +
> > > +     bus_cfg.bus_type = V4L2_MBUS_PARALLEL;
> >
> > Please zero the entire struct, i.e. do this assignment in the declaration.
> >
> Agreed, but instead at the declaration I would prefer here as below,
> since patch 2/3 has a comment related to backward compatibility with
> the bindings. Is this OK with you ?
>     bus_cfg = (struct v4l2_fwnode_endpoint)
>           { .bus_type = V4L2_MBUS_PARALLEL };

Why not in variable declaration?

-- 
Sakari Ailus